Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN/USER] feat: 축제 목록 화면 지역별 필터링 구현 (#768) #800

Merged
merged 12 commits into from
Apr 2, 2024
Merged

[AN/USER] feat: 축제 목록 화면 지역별 필터링 구현 (#768) #800

merged 12 commits into from
Apr 2, 2024

Conversation

EmilyCh0
Copy link
Member

📌 관련 이슈

✨ PR 세부 내용

  • 지난 회의에서 결정한대로 지역 클릭하면 바텀시트가 바로 닫히고 필터링 결과 나오도록 구현했습니다.
  • 메인 축제 화면의 지역별 칩은 별도 뷰홀더 만들지 않고 FestivalListTabViewHolder 에 포함시켰는데 분리가 필요하다 생각되면 코멘트 남겨주세요.
  • 새로고침 시에 필터링 조건이 남아있어야 할까요? 현재는 전체 조회로 리셋됩니다.

@EmilyCh0 EmilyCh0 added AN 안드로이드에 관련된 작업 USER labels Mar 20, 2024
@EmilyCh0 EmilyCh0 self-assigned this Mar 20, 2024
@github-actions github-actions bot requested review from re4rk and SeongHoonC March 20, 2024 14:19
re4rk
re4rk approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@re4rk re4rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
새로고침 시 필터링이 남아 있는 것이 지극히 개인적으로 다른 사이트를 이용했을 때 사용자 경험이 좋았던 것같아요!

SeongHoonC
SeongHoonC requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@SeongHoonC SeongHoonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지역별 필터링이 다시 바인딩 될 때 초기화됩니다!
버그 수정 후 재요청 바랍니다!

KakaoTalk_Video_2024-03-24-15-34-22.mp4

@EmilyCh0 EmilyCh0 requested review from SeongHoonC and re4rk March 31, 2024 00:22
@SeongHoonC
feat: 축제 목록 다른 탭 클릭 시 로딩중 임을 보여준다.
8a9e6f5
@SeongHoonC
Merge branch 'dev' into feat/#768
03aeb2c 
# Conflicts:
#	android/festago/presentation/src/main/java/com/festago/festago/presentation/ui/home/festivallist/FestivalListFragment.kt
#	android/festago/presentation/src/main/res/values/strings.xml
@SeongHoonC
chore: ktlint check
facf706
SeongHoonC
SeongHoonC approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@SeongHoonC SeongHoonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SeongHoonC SeongHoonC merged commit a5921ae into dev Apr 2, 2024
1 check passed
@SeongHoonC SeongHoonC deleted the feat/#768 branch April 2, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeongHoonC SeongHoonC SeongHoonC approved these changes

@re4rk re4rk Awaiting requested review from re4rk

Assignees

@EmilyCh0 EmilyCh0

Labels
AN 안드로이드에 관련된 작업 USER
Projects
2023-festa-go
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AN] 축제 목록 화면 지역별 필터링 구현
3 participants
@EmilyCh0 @re4rk @SeongHoonC